Post #4009029
2026-07-22 09:49 UTC
@timwolla@phpc.social updated the implementation with your different remarks
Replies (1)
-
@timwolla@phpc.social 2026-07-22 09:52
@nyamsprod@phpc.social Okay, the Overflow remark was ambiguous, I suppose: - Negative inputs are a programmer error (thus ValueError) - for now at least. - Out-of-range nanoseconds is also a programmer error. The TimeException only applies to overflow of the entire range (i.e. an overflow in seconds). I also suggest to test with `fromHours(PHP_INT_MAX)`. This will likely throw a TypeError internally, because of the int->double overflow. This should also be TimeException.