Post #3419112
2026-06-27 01:28 UTC
Cont.
If I check the whole queue 4x a day (or even 2x) to make sure CI is passing, SRP, SAST/Snyk passing, all the labels are right and accurate…I’d NEVER get anything done. The MR author HAS to be trusted to do those things.
If they don’t, it doesn’t get reviewed, because it doesn’t get seen. And, the ones that ARE ready to review, usually sail right though.
2/2
Replies (1)
-
@ian@phpc.social 2026-06-27 03:29
@ssemicolons@phpc.social For where I am and the last place I was, the understanding is that you can request a reviewer iff CI is green. If CI is red (very rare, because we respect each other) it gets sent back immediately. If there's no reviewer set, we catch it in a daily PR sweep at standup, and the submitter can't complain about review velocity if they didn't specify a reviewer (reviewer can swap workload to another person if needed). Seems to work okay.